Remove legacy discovery tools list_estimators, search_estimators in favour of new tools query_registry, describe_component#463
Open
Shashankss1205 wants to merge 4 commits into
Conversation
Shashankss1205
changed the title
fkiraly
requested changes
Jun 4, 2026
fkiraly
left a comment
fkiraly
left a comment
Collaborator
There was a problem hiding this comment.
Overall, this looks like an improvement.
However, can you please make sure to include docstrings to all important functions and classes? Please have a look how sktime does this. Preferably in the same numpydoc adjacent style that sktime uses.
Otherwise, it becomes really hard to review changes, especially if they are subtle changes.
E.g., I have the question what the new target variable means and which values it can assume, but there is no piece of documentation that would tell me.
Collaborator
Author
|
@fkiraly thanks for the feedback, I will try updating all of the PRs with the suitable doc strings to let the maintainers understand the pieces of code easily... |
Shashankss1205
force-pushed
the
feature/remove-legacy-discovery-tools
branch
from
4210aa1 to
398213e
Compare
Shashankss1205
force-pushed
the
feature/remove-legacy-discovery-tools
branch
from
58dbd7b to
fa67c43
Compare
Shashankss1205
changed the title
Shashankss1205
force-pushed
the
feature/remove-legacy-discovery-tools
branch
2 times, most recently
from
ebb9548 to
cf98e76
Compare
…cribe_estimator, get_available_tags in favor of unified query_registry and describe_component everywhere
…r and return schema documentation
Add accurate query_registry and describe_component tool schemas in server.py, document that tag values are typed (not all boolean), and remove the redundant hyperparameters key from describe_component responses. Co-authored-by: Cursor <cursoragent@cursor.com>
Shashankss1205
force-pushed
the
feature/remove-legacy-discovery-tools
branch
from
cf98e76 to
925b8d6
Compare
Collaborator
Author
|
Heyy @fkiraly can you please check the latest state of this PR? |
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #461
Independence: This PR is rebased on latest
mainand does not depend on any other open PR. It can be merged on its own.What does this implement/fix? Explain your changes.
This pull request removes the legacy discovery tools (
list_estimators,search_estimators,describe_estimator, andget_available_tags) and routes discovery through unified replacements:query_registry— unified registry search (estimators, tags, metrics)describe_component— detailed info for any sktime component classChanges:
server.pydescribe_estimator.py→describe_component.pylist_estimators.pyinternals used byquery_registrytests/test_core.pyandtests/test_discovery_consolidated.pyREADME.md,docs/source/implementation.md,docs/source/usage-examples.mdDoes your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
query_registryanddescribe_componentwork for estimators, tags, and paginationAny other comments?
Rebased on latest
main.make checkpasses locally.PR checklist
For all contributions
make check).docs/source/.